Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional default noise models to devices #676

Merged
merged 17 commits into from
Apr 26, 2024
Merged

Conversation

HGSilveri
Copy link
Collaborator

@HGSilveri HGSilveri commented Apr 22, 2024

  • Adds default_noise_model field to device classes
  • Adds prefer_device_noise_model option to EmulatorConfig
  • Updates JSON schema to include NoiseModel
  • Support NoiseModel serialization and deserialization
  • Make NoiseModel fully immutable and comparable with __eq__()
  • Move pulser.backends.noise_model to pulser.noise_model

Closes #591 .

@HGSilveri HGSilveri requested a review from a-corni April 25, 2024 16:05
@HGSilveri HGSilveri marked this pull request as ready for review April 25, 2024 16:05
Copy link
Collaborator

@a-corni a-corni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good then !

@HGSilveri HGSilveri merged commit 4981ca6 into develop Apr 26, 2024
7 checks passed
@HGSilveri HGSilveri deleted the hs/default-noise branch April 26, 2024 15:02
@HGSilveri HGSilveri mentioned this pull request Apr 29, 2024
HGSilveri added a commit that referenced this pull request Apr 29, 2024
Main changes:

21a47f3 Remove Register.rotate() (#642)
20e6765 FIX: Redefine slope of RampWaveform (#644)
c2d5b6c Enabling definition of multiple noise channels and noise channels in XY (#647)
bcb78cc Enable digital simulation (#652)
0f6e3dd Improve access to output modulation durations (#663)
188d21d Remove deprecated noise arguments (#674)
f303138 Adding relaxation noise channel (#675)
716b86b Centralize all backend imports from a single pulser.backends module (#678)
96a8c34 Add hyperfine dephasing rate to NoiseModel (#680)
4981ca6 Add optional default noise models to devices (#676)
c695373 Rectangular lattice register and layout (#665)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default noise models for devices
2 participants